fix(auth): log failures as warn when enforcement is off so we get them in prod#387
Merged
fix(auth): log failures as warn when enforcement is off so we get them in prod#387
Conversation
jan-auer
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
escalates the log level for auth failures to
warn!()when enforcement is disabled.when enforcement is disabled, the presumption is you are working to enable it. failures are surfaced as warnings so you can fix all outstanding integration issues before enabling. if any clients haven't deployed auth config yet this will be very noisy.
when enforcement is enabled (after a safe rollout), auth failures aren't indicative of a problem with objectstore so they are only logged at debug level.