test: Add tests for GCS multipart uploads#454
Open
lcian wants to merge 4 commits intolcian/feat/gcs-multipart-implfrom
Open
test: Add tests for GCS multipart uploads#454lcian wants to merge 4 commits intolcian/feat/gcs-multipart-implfrom
lcian wants to merge 4 commits intolcian/feat/gcs-multipart-implfrom
Conversation
lcian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds e2e tests against our fork of https://github.com/googleapis/storage-testbench, which contains an XML API multipart upload implementation https://github.com/getsentry/google-cloud-storage-testbench
Also switches devservices to use that fork.
The implementation present in this fork has been completely written by LLMs, so it should not be trusted for anything but catching obvious regressions if we ever make changes to the GCS backend.
Any non-trivial change to the GCS backend that touches the multipart upload implementation should be tested in sandbox against real GCS before merging.
I've added a code comment about this too.
Part of #450, will be merged into it.
Part of FS-338