fix(dev): Try workaround to get maturin to include license file#81
Merged
lobsterkatie merged 1 commit intomasterfrom Apr 30, 2025
Merged
fix(dev): Try workaround to get maturin to include license file#81lobsterkatie merged 1 commit intomasterfrom
lobsterkatie merged 1 commit intomasterfrom
Conversation
Swatinem
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pypi expects us to declare the license file according to PEP 639, but maturin doesn't yet support it. Another maturin user posted a workaround, to try to get maturin to include the license file in the tarball, which this PR implements.
(There is a draft PR in the maturin repo to add support for PEP 639, but as of now it seems incomplete. If/when that's completed, merged, and released, we can update maturin and then fix the license specification as is done in #80.)