Skip to content

Improve skills architecture based on Sentry warden and junior-prod patterns#63

Merged
MathurAditya724 merged 3 commits into
mainfrom
improve-skills-from-sentry-patterns
May 8, 2026
Merged

Improve skills architecture based on Sentry warden and junior-prod patterns#63
MathurAditya724 merged 3 commits into
mainfrom
improve-skills-from-sentry-patterns

Conversation

@MathurAditya724
Copy link
Copy Markdown
Member

Overhaul the skills system based on patterns observed in getsentry/warden (LLM code review agent) and getsentry/junior-prod (Slack-native AI bot).

Changes

  • SPEC.md for every skill — maintenance contracts defining intent, scope, runtime contracts, and evaluation criteria (pattern from both Sentry repos)
  • References directories — focused sub-documents for resolve-issue, review, and fix-ci enabling conditional context loading instead of monolithic prompts
  • Confidence calibration — review skill now requires HIGH/MEDIUM/LOW classification; LOW findings are dropped
  • Not-a-finding guide — explicit list of patterns that look wrong but are typically correct, reducing false positives
  • Investigation-first mandate — resolve-issue now requires articulating "this breaks because X, in Y path, after Z condition" before editing
  • Verification harness table — match change shape to verification method (unit test, integration test, build, lint, etc.)
  • Expanded deslop patterns — additional AI noise patterns (redundant type annotations, unnecessary else after return, debug logging, verbose names)
  • Conventional commit titles — pr skill now checks repo history and uses conventional commit format when appropriate
  • Self-update skill — new skill for automated dependency maintenance
  • Softer imperative language — reduced anchoring from excessive MUST/NEVER without removing safety constraints

What was NOT changed

  • webhooks.json — no changes to event routing, email handling, or trigger configuration
  • Email triage logic in github-agent.md — untouched to avoid notification regressions
  • Core triage logic — no changes to skip conditions or event handling
  • No TypeScript/application code changes — this PR is skills/prompts only

Testing

Skills are markdown-based prompts; no runtime tests apply. Verified via manual review of all diffs.

Closes: N/A (improvement initiative)

…d junior-prod

- Add SPEC.md maintenance contracts to all 11 skills defining intent,
  scope, runtime contracts, and evaluation criteria
- Add references/ directories for complex skills (resolve-issue, review,
  fix-ci) with focused sub-documents for conditional loading
- Add confidence calibration and not-a-finding guide to review skill
  to reduce false positives
- Add investigation-first mandate and verification harness table to
  resolve-issue for better root cause analysis
- Expand deslop anti-pattern list with additional AI noise patterns
- Add conventional commit title guidance to pr skill
- Add self-update skill for dependency maintenance
- Add auto-merge and self-update to github-agent utility skill list
- Soften imperative language where it causes anchoring without
  safety benefit
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 8, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
opencode-email-worker 8874c79 Commit Preview URL

Branch Preview URL
May 08 2026, 01:43 AM

- mark-pr-ready SPEC: acknowledge auto-merge as successor skill
- review SPEC: add reference to not-a-finding.md in evaluation criteria
- deslop SPEC: list all 9 slop patterns from the updated SKILL.md
@MathurAditya724 MathurAditya724 marked this pull request as ready for review May 8, 2026 01:19
@MathurAditya724 MathurAditya724 merged commit c99e081 into main May 8, 2026
2 checks passed
@MathurAditya724 MathurAditya724 deleted the improve-skills-from-sentry-patterns branch May 8, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant