-
-
Notifications
You must be signed in to change notification settings - Fork 5
build: pin click version to correct version #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e3d568 to
6f6ad41
Compare
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
d6e4abd to
d0bf7fe
Compare
553aa9e to
09c21dc
Compare
ajay-sentry
approved these changes
Sep 18, 2025
Contributor
|
More context of the Click update hitting other projects: jazzband/pip-tools#2236. |
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Sep 22, 2025
This excludes the incompatible version of Click v8.3.0 from the dependency resolution. Refs: * getsentry/prevent-cli#95 * pallets/click#3066
Contributor
I bet it's the |
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Sep 22, 2025
This excludes the incompatible version of Click v8.3.0 from the dependency resolution. Refs: * getsentry/prevent-cli#95 * pallets/click#3066
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Sep 22, 2025
This excludes the incompatible version of Click v8.3.0 from the dependency resolution. Refs: * getsentry/prevent-cli#95 * pallets/click#3066
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Sep 23, 2025
This excludes the incompatible version of Click v8.3.0 from the dependency resolution. Refs: * getsentry/prevent-cli#95 * pallets/click#3066
webknjaz
added a commit
to ansible/ansible
that referenced
this pull request
Sep 23, 2025
PR #85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Sep 23, 2025
PR ansible#85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba) Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Sep 23, 2025
PR ansible#85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba)
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Sep 23, 2025
PR ansible#85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba)
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Sep 23, 2025
PR ansible#85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba)
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Sep 23, 2025
PR ansible#85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba)
This was referenced Sep 23, 2025
mattclay
pushed a commit
to ansible/ansible
that referenced
this pull request
Sep 29, 2025
PR #85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba)
mattclay
added a commit
to ansible/ansible
that referenced
this pull request
Sep 29, 2025
* [stable-2.18] Use codecov-cli for uploads (#85386) ci_coverage ci_complete (cherry picked from commit 4a03ccb) Co-authored-by: Matt Clay <matt@mystile.com> * 🧪 Pin codecov-cli deptree used in AZP PR #85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba) --------- Co-authored-by: Matt Clay <matt@mystile.com>
mattclay
added a commit
to ansible/ansible
that referenced
this pull request
Sep 29, 2025
* Use codecov-cli for uploads (#85386) ci_coverage ci_complete (cherry picked from commit 4a03ccb) * 🧪 Pin codecov-cli deptree used in AZP PR #85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba) --------- Co-authored-by: Matt Clay <matt@mystile.com>
mattclay
added a commit
to ansible/ansible
that referenced
this pull request
Sep 29, 2025
* Use codecov-cli for uploads (#85386) ci_coverage ci_complete (cherry picked from commit 4a03ccb) * 🧪 Pin codecov-cli deptree used in AZP PR #85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba) --------- Co-authored-by: Matt Clay <matt@mystile.com>
mattclay
added a commit
to ansible/ansible
that referenced
this pull request
Sep 29, 2025
* Use codecov-cli for uploads (#85386) ci_coverage ci_complete (cherry picked from commit 4a03ccb) * 🧪 Pin codecov-cli deptree used in AZP PR #85888 `codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that. To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`. Refs: * getsentry/prevent-cli#95 * pallets/click#3066 ci_coverage ci_complete (cherry picked from commit 1e572ba) * Unignore `publish-codecov.py` sanity violations --------- Co-authored-by: Matt Clay <matt@mystile.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manually tested that 8.3.0 is causing the commit sha not found cli issue so i'm manually pinning the version to avoid that for now. not sure what the root cause is, just treating the symptom that 8.3 breaks things for now. See previous commits on this PRs' CI runs for the proof that 8.3 is broken