Skip to content

Conversation

@joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Sep 18, 2025

I manually tested that 8.3.0 is causing the commit sha not found cli issue so i'm manually pinning the version to avoid that for now. not sure what the root cause is, just treating the symptom that 8.3 breaks things for now. See previous commits on this PRs' CI runs for the proof that 8.3 is broken

@codecov
Copy link

codecov bot commented Sep 18, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
695 1 694 1
View the full list of 1 ❄️ flaky tests
api.temp.calculator.test_calculator::test_divide

Flake rate in main: 99.75% (Passed 12 times, Failed 4801 times)

Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@joseph-sentry joseph-sentry changed the title Joey/fix build build: pin click version to correct version Sep 18, 2025
@joseph-sentry joseph-sentry merged commit eb97892 into main Sep 18, 2025
26 checks passed
@joseph-sentry joseph-sentry deleted the joey/fix-build branch September 18, 2025 22:37
@webknjaz
Copy link
Contributor

More context of the Click update hitting other projects: jazzband/pip-tools#2236.

webknjaz added a commit to webknjaz/ansible that referenced this pull request Sep 22, 2025
This excludes the incompatible version of Click v8.3.0 from the
dependency resolution.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066
@webknjaz
Copy link
Contributor

root cause is

I bet it's the Sentinel.UNSET changes in Click.

webknjaz added a commit to webknjaz/ansible that referenced this pull request Sep 22, 2025
This excludes the incompatible version of Click v8.3.0 from the
dependency resolution.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066
webknjaz added a commit to webknjaz/ansible that referenced this pull request Sep 22, 2025
This excludes the incompatible version of Click v8.3.0 from the
dependency resolution.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066
webknjaz added a commit to webknjaz/ansible that referenced this pull request Sep 23, 2025
This excludes the incompatible version of Click v8.3.0 from the
dependency resolution.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066
webknjaz added a commit to ansible/ansible that referenced this pull request Sep 23, 2025
PR #85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete
webknjaz added a commit to webknjaz/ansible that referenced this pull request Sep 23, 2025
PR ansible#85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete
(cherry picked from commit 1e572ba)

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
webknjaz added a commit to webknjaz/ansible that referenced this pull request Sep 23, 2025
PR ansible#85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete

(cherry picked from commit 1e572ba)
webknjaz added a commit to webknjaz/ansible that referenced this pull request Sep 23, 2025
PR ansible#85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete

(cherry picked from commit 1e572ba)
webknjaz added a commit to webknjaz/ansible that referenced this pull request Sep 23, 2025
PR ansible#85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete

(cherry picked from commit 1e572ba)
webknjaz added a commit to webknjaz/ansible that referenced this pull request Sep 23, 2025
PR ansible#85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete

(cherry picked from commit 1e572ba)
mattclay pushed a commit to ansible/ansible that referenced this pull request Sep 29, 2025
PR #85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete
(cherry picked from commit 1e572ba)
mattclay added a commit to ansible/ansible that referenced this pull request Sep 29, 2025
* [stable-2.18] Use codecov-cli for uploads (#85386)

ci_coverage
ci_complete
(cherry picked from commit 4a03ccb)

Co-authored-by: Matt Clay <matt@mystile.com>

* 🧪 Pin codecov-cli deptree used in AZP

PR #85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete

(cherry picked from commit 1e572ba)

---------

Co-authored-by: Matt Clay <matt@mystile.com>
mattclay added a commit to ansible/ansible that referenced this pull request Sep 29, 2025
* Use codecov-cli for uploads (#85386)

ci_coverage
ci_complete

(cherry picked from commit 4a03ccb)

* 🧪 Pin codecov-cli deptree used in AZP

PR #85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete

(cherry picked from commit 1e572ba)

---------

Co-authored-by: Matt Clay <matt@mystile.com>
mattclay added a commit to ansible/ansible that referenced this pull request Sep 29, 2025
* Use codecov-cli for uploads (#85386)

ci_coverage
ci_complete

(cherry picked from commit 4a03ccb)

* 🧪 Pin codecov-cli deptree used in AZP

PR #85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete

(cherry picked from commit 1e572ba)

---------

Co-authored-by: Matt Clay <matt@mystile.com>
mattclay added a commit to ansible/ansible that referenced this pull request Sep 29, 2025
* Use codecov-cli for uploads (#85386)

ci_coverage
ci_complete

(cherry picked from commit 4a03ccb)

* 🧪 Pin codecov-cli deptree used in AZP

PR #85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With getsentry/prevent-cli#95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* getsentry/prevent-cli#95
* pallets/click#3066

ci_coverage
ci_complete

(cherry picked from commit 1e572ba)

* Unignore `publish-codecov.py` sanity violations

---------

Co-authored-by: Matt Clay <matt@mystile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants