This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Check if module exists before loading. Compile if missing #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
JonasBa
reviewed
Mar 28, 2023
scripts/check-build.js
Outdated
| console.log('@sentry/profiling-node: Precompiled binary found, attempting to load...'); | ||
| require(target); | ||
| console.log('@sentry/profiling-node: Precompiled binary found, skipping build from source.'); | ||
| if(!existsSync(target)) { |
Member
There was a problem hiding this comment.
Lgtm, do you mind just inverting these two conditions for readability and drop the negation?
if(exists){
require
} else {
recompile
}
Contributor
Author
There was a problem hiding this comment.
yup! just pushed the requested changes
JonasBa
approved these changes
Mar 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #121