feat(workflow): only poll accepted issues, add ci-failed state machine#7834
Merged
Conversation
Changes the poller to only check issues with BOTH ci-pending AND accepted labels. Abandoned releases without approval cost zero. When CI fails: - Swaps ci-pending → ci-failed (red label) - Removes accepted label - Comments with failed check names and link To retry after fixing CI, re-add the accepted label. publish.yml detects ci-failed + accepted, swaps back to ci-pending, and immediately triggers the poller via workflow_dispatch. State machine: opened → ci-pending accepted added → poller starts checking CI passes → ci-ready → publish CI fails → ci-failed, accepted removed → waiting for human accepted re-added → ci-pending → poller retries
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit efb9fac. Configure here.
…cepted Since we now only query issues with both ci-pending and accepted labels, has_accepted is always true. Replace the conditional with the single "publishing is starting now" message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Two changes to eliminate wasted polling on abandoned releases:
1. Only poll issues with both
ci-pendingANDacceptedThe poller now ignores issues that nobody has approved. Abandoned releases with
ci-pendingbut noacceptedlabel cost zero poller time.2. CI failure →
ci-failedlabel + removeacceptedWhen CI fails, the poller:
ci-pending→ci-failed(red label)acceptedso the poller stops checking this issueTo retry: fix CI, then re-add the
acceptedlabel.publish.ymldetectsci-failed+accepted, swaps back toci-pending, comments, and immediately triggers the poller viaworkflow_dispatch(using app token).State machine
Changes
ci-poller.yml: Filter by--label ci-pending --label accepted. On failure: swap labels, remove accepted, comment.publish.yml:waiting-for-cijob handlesci-failed→ci-pendingswap whenacceptedis re-added. Triggers poller viagh workflow runwith app token. Publish gate now also excludesci-failed.Pre-requisite (already done)
Created
ci-failedlabel (red#D93F0B) in the repo.