This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Make the UnitTests project .NET 4.0 #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk because replacement isn't done in place, but returned as a new string instance. - Added failing CreditCardFilter test, unveiling a bug in the filter that leads to an IndexOutOfRangeException.
… making PhoneNumberFilterTests.Filter_PhoneNumberIsScrubbed() green.
…n invalid credit card number and added a positive test for a valid credit card number
…fer from ArgumentOutOfRangeException problems.
…e name of the test fixture
…o not contain "Filter".
Contributor
Author
|
I also pushed a couple of new tests to this branch, because I found some bugs in the |
Member
|
I feel really bad for C# devs after this patch :( SO MUCH CODE |
dcramer
added a commit
that referenced
this pull request
Dec 6, 2013
Make the UnitTests project .NET 4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UnitTests project was erroneously set to .NET 4.5, so this pull request just dumps it down to 4.0. This should fix the build problem on TeamCity.