This repository was archived by the owner on Aug 30, 2023. It is now read-only.
NuGet package #39
Merged
NuGet package #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te some helpful comments.
…InformationalVersion, so remove it (for now).
…at TeamCity should agree with
…g goodness. Resolved conflicts: SharpRaven.sln SharpRaven/Properties/AssemblyInfo.cs SharpRaven/SharpRaven.csproj packages/repositories.config
…of SharpRaven.UnitTests
… because replacement isn't done in place, but returned as a new string instance.
… making PhoneNumberFilterTests.Filter_PhoneNumberIsScrubbed() green.
…at leads to an IndexOutOfRangeException.
…n invalid credit card number and added a positive test for a valid credit card number
… because replacement isn't done in place, but returned as a new string instance.
… because replacement isn't done in place, but returned as a new string instance.
…at leads to an IndexOutOfRangeException.
…n invalid credit card number and added a positive test for a valid credit card number
…fer from ArgumentOutOfRangeException problems.
- Added failing test for the PhoneNumberFilter, proving it doesn't work because replacement isn't done in place, but returned as a new string instance. - Added failing CreditCardFilter test, unveiling a bug in the filter that leads to an IndexOutOfRangeException.
…en a NuGet build is executed in TeamCity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements everything mentioned in issue #17, so I believe that can be closed once this is merged. When it is, I'll rejig the required stuff in TeamCity to create a NuGet package from master. I will also try to delete the raven-csharp package so there won't be any confusion over which package is the official one.