This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Better recursive poison, perhaps?#102
Closed
connor4312 wants to merge 5 commits into
Closed
Conversation
|
The latest code I pushed to https://github.com/isaacs/json-stringify-safe might do the trick in 27 lines. Would you mind giving it a try? Thanks! |
Contributor
|
Hey, I'd love to get this PR merged. I know it's been some time and you may barely remember this, but is there any chance you can add tests? |
Contributor
Author
|
Hey, sure. I'll take a look at updating this when I get a moment. |
benvinegar
added a commit
that referenced
this pull request
Jul 29, 2016
Contributor
|
Closed in favor of #182 |
benvinegar
added a commit
that referenced
this pull request
Jul 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests pass... seems to work, but I wouldn't bet my life that it covers every edge case.
In regards to #91
This change is