Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Update sorely out-of-date docs#183

Merged
benvinegar merged 2 commits into
masterfrom
update-docs
Aug 1, 2016
Merged

Update sorely out-of-date docs#183
benvinegar merged 2 commits into
masterfrom
update-docs

Conversation

@benvinegar

@benvinegar benvinegar commented Jul 29, 2016

Copy link
Copy Markdown
Contributor

Most of the language was taken from raven-js, where the options are identical.

cc @macqueen @mattrobenolt


This change is Reviewable

Comment thread docs/config.rst
{
dataCallback: function(data) {
// remove references to the environment
delete data.request.env;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no more request.env / process.env ... updated this example to set a user.

@macqueen

Copy link
Copy Markdown

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


docs/config.rst, line 42 [r2] (raw file):

        {
          release: 'staging'

should this be environment: 'staging'?


Comments from Reviewable

@macqueen

Copy link
Copy Markdown

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@benvinegar benvinegar merged commit 47279ef into master Aug 1, 2016
@benvinegar benvinegar deleted the update-docs branch August 1, 2016 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants