This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Fixed express deprecation warning#412
Closed
AmazingTurtle wants to merge 1 commit into
Closed
Conversation
"express deprecated req.host: Use req.hostname instead" has been fixed
Contributor
|
Raised into #96 (comment) |
Skn0tt
approved these changes
Dec 29, 2017
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
Works perfectly :D
Just wanted to fix this as well, but saw that there's already a PR.
Contributor
|
This change will break accessing |
Contributor
|
Express is 50 times more used than Koa. But getOwnPropertyDescriptor() should do the job. |
Contributor
|
@oliviertassinari, unfortunately, it's not enough, but I still wrote a workaround for this. Hope it helps :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"express deprecated req.host: Use req.hostname instead" has been fixed