Cannot capture exception when used with genshi

[rslinckx]

When trying to render a genshi template with raven enabled I get the following traceback:

Traceback (most recent call last):
File "/Users/kikidonk/Whatever/env/kp/lib/python2.7/site-packages/flask/app.py", line 1506, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/Users/kikidonk/Whatever/env/kp/lib/python2.7/site-packages/flask/app.py", line 1181, in handle_exception
got_request_exception.send(self, exception=e)
File "/Users/kikidonk/Whatever/env/kp/lib/python2.7/site-packages/blinker/base.py", line 220, in send
for receiver in self.receivers_for(sender)]
File "/Users/kikidonk/Whatever/env/kp/lib/python2.7/site-packages/raven/contrib/flask/init.py", line 31, in _handle_exception
'app': sender.name,
File "/Users/kikidonk/Whatever/env/kp/lib/python2.7/site-packages/raven/base.py", line 219, in capture
data.update(processor.process(data))
File "/Users/kikidonk/Whatever/env/kp/lib/python2.7/site-packages/raven/processors.py", line 28, in process
for k, v in frame['vars'].iteritems():
AttributeError: 'str' object has no attribute 'iteritems'

It seems that frame['vars'] contains a string...

In utils/stacks.py:149 I see that 'vars': transform(frame.f_locals)

And upon inspection it seems that frame.f_locals is a list with a single item being a dict containing the genshi variables.

I'm guessing the transform sees a list and then stringifies it, but then other code expects it to be a dict (which it really should be).

Maybe genshi does weird stuff with f_locals ?

[dcramer]

I think genshi actually is messing up f_locals. I'll ask around. This is definitely something we should handle gracefully either way.

(e.g. we shouldn't support trying to figure out how locals is, but we shouldn't error when its not a dict)

[dcramer]

Fixed in a610ebf

[dcramer]

Even better support for these kind of objects in 73dfafa