This repository was archived by the owner on Oct 23, 2023. It is now read-only.
fix(flask): Add app.logger instrumentation #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of flask set app.logger.propagate to False, and it's reasonable to expect that users except app.logger to be instrumented if explictly setting logger=True in the sentry client. Fixes: PY-RAVEN #1030 app.logger log call messages are not send to sentry
mitsuhiko
approved these changes
Sep 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of flask set app.logger.propagate to False,
and it's reasonable to expect that users except app.logger
to be instrumented if explictly setting logger=True in the
sentry client.
Fixes: PY-RAVEN #1030 app.logger log call messages are not send to
sentry