Gearman support

[char0n]

I have implemented gearman support for raven sentry client. For more information what gearman is, and what is does please refer to http://gearman.org/.

This pull request includes:

• gearman support
• tests
• documentation

[coveralls]

Coverage increased (+0%) when pulling 2a78870 on CodeScaleInc:master into d0bd88f on getsentry:master.

[coveralls]

Coverage increased (+0%) when pulling 952bc87 on CodeScaleInc:master into d0bd88f on getsentry:master.

[xordoquy]

Hi,

Thanks for your pull request.
I just had a small look at it.
Is there any reason why you need to introduce new django commands with the raven client ?
Will the regular Django client still work if one doesn't have gearman installed ?

[xordoquy]

Keeping the comma avoid to see that line in the diffs if we had another item in the list after it.

[char0n]

Is there any reason why you need to introduce new django commands with the raven client ?

The reason is, that gearman workers are implemented via https://github.com/CodeScaleInc/django-gearman-commands app. Basically it is classic django command, that runs in infinite loop and process jobs from gearman daemon in separate thread. For more information how this works, please visit the github repo for django-gearman-commands.

Will the regular Django client still work if one doesn't have gearman installed ?

Yes it will. This is my setting from django project.

SENTRY_CLIENT = 'raven.contrib.django.gearman.GearmanClient'
RAVEN_CONFIG = {
'dsn': 'secret_dns_string,
'timeout': 3
}

Only when using GearmanClient in your settings, gearman daemon is required. When your are using GearmanClient and gearman daemon is not installed ConnectionError is raised. When using standard DjangoClient, gearman daemon is no required at all.

I hope this answered your questions.

[dcramer]

IIRC this will force raven_gearman.py to be imported as part of Django's cycle, which would then throw an ImportError for anyone not using the gearman controls

[char0n]

I see your point now. I can make a little modification in raven_gearman.py then:

from future import absolute_import
from django.conf import settings

if gettattr('RAVEN_CONFIG', settings) == 'raven.contrib.django.gearman.GearmanClient':
from raven.contrib.gearman.worker import Command
else:
# Create dummy command that does nothing

Will this be satisfactory ?

[xordoquy]

It looks a bit tricky to me.
Can't there be a django_gearman or simply gearman contrib module -ie out of the django one- which will be used if gearman is used and keep things as they already are with django ?

[dcramer]

Ya ideally something like contrib.django.raven.gearman (or whatever namespace makes sense) that you can drop in your INSTALLED_APPS

[char0n]

Ok sounds good. I can make contrib.django.gearman as an django app that can be dropped easily in INSTALLED_APPS.

[xordoquy]

You need to add

from __future__ import absolute_import

on top of your files so that the builds can be run by travis

[xordoquy]

ok, I'm going to close this. Note that raven will undergo this year a movement to split specific framework appart from the core.