Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Conversation

@mindflayer
Copy link

Flask plugin is not intercepting explicit exceptions sent via: sentry.captureException()

Flask plugin is not intercepting explicit exceptions sent via:
sentry.captureException()
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1755c60 on mindflayer:master into 7ddbb49 on getsentry:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1755c60 on mindflayer:master into 7ddbb49 on getsentry:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 1755c60 on mindflayer:master into 7ddbb49 on getsentry:master.

@xordoquy
Copy link
Contributor

Do you have a test case for that issue ?

@mindflayer
Copy link
Author

I've tried in a real case, but if you see the Django one does the same, and it sends exc_info as well.

def sentry_exception_handler(request=None, **kwargs):
    exc_info = sys.exc_info()

    if exc_info[0].__name__ in get_option('IGNORE_EXCEPTIONS', ()):
        logger.info(
            'Not capturing exception due to filters: %s', exc_info[0],
            exc_info=exc_info)
        return

    try:
        client.captureException(exc_info=exc_info, request=request)
    except Exception as exc:
        try:
            logger.exception('Unable to process log entry: %s' % (exc,))
        except Exception as exc:
            warnings.warn('Unable to process log entry: %s' % (exc,))

@mindflayer
Copy link
Author

I'll try to understand how to replicate the behaviour I've got here.

@dcramer
Copy link
Member

dcramer commented Jul 17, 2013

Considering capture does exc_info = sys.exc_info() I dont quite understand how it could not work

Its capturing just without the exception? Can you give the version of Flask as well.

@dcramer
Copy link
Member

dcramer commented Aug 6, 2013

Feel free to reopen if you discover anything (or can show this with a test)

@dcramer dcramer closed this Aug 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants