This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Django client's get_data_from_request method did not correctly assign request.POST #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xordoquy
added a commit
that referenced
this pull request
Sep 10, 2013
Django client's get_data_from_request method did not correctly assign request.POST
Contributor
Author
|
@xordoquy Do you want me to fix the test? I see that the test for this PR is failing older version of django |
Contributor
|
@SeiryuZ thanks for your proposal, I fixed them yesterday ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix Raven's django client assigning string
<unavailable>onresult['sentry.interfaces.Http']['data']on methodget_data_from_request, even when we have correct POST variables in the request.Also in this PR, I added test case for this issue
Before:
Result after this change: