This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Don't ignore records for all modules starting with "raven" #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR. |
xordoquy
added a commit
that referenced
this pull request
Oct 1, 2013
Don't ignore records for all modules starting with "raven"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently raven's logging handler ignores any errors coming from modules beginning with "raven", even though the module may not actually belong to raven and may be called something like "raven_utils". This change alters the logic to check for either an exact match on "raven", or a path starting with "raven." (including the namespace separator). This should cover both cases and allow for logging of errors from "raven_utils" but not from any module belonging to raven itself.