This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Fixes the BaseUDPTransport to use IPv4 by default #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using the first IPv4 address by default as per the documentation
dcramer
added a commit
that referenced
this pull request
Nov 29, 2013
Fixes the BaseUDPTransport to use IPv4 by default
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a matching patch for getsentry/sentry#1073
getaddrinfo() does not make any guarantees about the ordering of IPv4 vs IPv6 addresses and BaseUDPTransport was just picking the first address from getaddrinfo. This patch will fall back to using the first IPv4 address by default as per the documentation.