Skip to content

Fix #539 : Update sentry.gradle#546

Merged
HazAT merged 1 commit intogetsentry:masterfrom
matthieupinte:patch-1
Feb 12, 2019
Merged

Fix #539 : Update sentry.gradle#546
HazAT merged 1 commit intogetsentry:masterfrom
matthieupinte:patch-1

Conversation

@matthieupinte
Copy link
Copy Markdown
Contributor

Fix provided by @icfr for issue #539

cf. #539 (comment)

@matthieupinte matthieupinte requested a review from HazAT as a code owner February 12, 2019 09:42
Copy link
Copy Markdown
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🥇
Thanks :)

@HazAT HazAT merged commit 5622df9 into getsentry:master Feb 12, 2019
@matthieupinte matthieupinte deleted the patch-1 branch February 13, 2019 10:08
@ldco2016
Copy link
Copy Markdown

When I run a ./gradlew clean build, my terminal complains about this:

The TaskInternal.executer property has been deprecated and is scheduled to be removed in Gradle 5.0. There are better ways to re-use task logic, see https://docs.gradle.org/4.4/userguide/custom_tasks.html#sec:reusing_task_logic.
        at sentry_c79fxbhuascug468f001tukcq$_run_closure1$_closure6.doCall(/Users/danale/Projects/engage-application.mobile/node_modules/react-native-sentry/sentry.gradle:19)

I upgraded to the latest version you guys have, it seems gradle does not like this line:

def props = bundleTask.getProperties() is there a fix or workaround for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants