Skip to content

chore(beta): Address lint errors for next stable #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olksdr merged 1 commit into from
Oct 20, 2023
Merged

chore(beta): Address lint errors for next stable #2642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions relay-event-normalization/src/normalize/user_agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ impl<S: AsRef<str> + Default> RawUserAgentInfo<S> {

impl RawUserAgentInfo<String> {
/// The name of the user agent HTTP header.
pub const USER_AGENT: &str = "User-Agent";
pub const USER_AGENT: &'static str = "User-Agent";

/// Converts to a borrowed `RawUserAgentInfo`.
pub fn as_deref(&self) -> RawUserAgentInfo<&str> {
Expand Down Expand Up @@ -248,10 +248,10 @@ impl ClientHints<String> {
///
/// `Sec-CH-UA-Platform` is a low entropy hint. Unless blocked by a user agent permission
/// policy, it is sent by default (without the server opting in by sending `Accept-CH`).
pub const SEC_CH_UA_PLATFORM: &str = "SEC-CH-UA-Platform";
pub const SEC_CH_UA_PLATFORM: &'static str = "SEC-CH-UA-Platform";

/// Provides the version of the operating system on which the user agent is running.
pub const SEC_CH_UA_PLATFORM_VERSION: &str = "SEC-CH-UA-Platform-Version";
pub const SEC_CH_UA_PLATFORM_VERSION: &'static str = "SEC-CH-UA-Platform-Version";

/// Provides the user agent's branding and significant version information.
///
Expand All @@ -270,10 +270,10 @@ impl ClientHints<String> {
///
/// `Sec-CH-UA` is a low entropy hint. Unless blocked by a user agent permission policy, it is
/// sent by default (without the server opting in by sending `Accept-CH`).
pub const SEC_CH_UA: &str = "SEC-CH-UA";
pub const SEC_CH_UA: &'static str = "SEC-CH-UA";

/// Indicates the device model on which the browser is running.
pub const SEC_CH_UA_MODEL: &str = "SEC-CH-UA-Model";
pub const SEC_CH_UA_MODEL: &'static str = "SEC-CH-UA-Model";

/// Returns an instance of `ClientHints` that borrows from the original data.
pub fn as_deref(&self) -> ClientHints<&str> {
Expand Down
6 changes: 3 additions & 3 deletions relay-server/src/extractors/forwarded_for.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ use axum::http::HeaderMap;
pub struct ForwardedFor(String);

impl ForwardedFor {
const FORWARDED_HEADER: &str = "X-Forwarded-For";
const VERCEL_FORWARDED_HEADER: &str = "X-Vercel-Forwarded-For";
const SENTRY_FORWARDED_HEADER: &str = "X-Sentry-Forwarded-For";
const FORWARDED_HEADER: &'static str = "X-Forwarded-For";
const VERCEL_FORWARDED_HEADER: &'static str = "X-Vercel-Forwarded-For";
const SENTRY_FORWARDED_HEADER: &'static str = "X-Sentry-Forwarded-For";

/// We prefer the SENTRY_FORWARDED_HEADER over the standard header because our infrastructure
/// puts the contents of the incoming FORWARDED_HEADER into SENTRY_FORWARDED_HEADER for security
Expand Down