Skip to content

fix(replays): Use different enforcement category for replay video#4459

Merged
cmanallen merged 5 commits into
masterfrom
cmanallen/replays-video-new-category
Jan 21, 2025
Merged

fix(replays): Use different enforcement category for replay video#4459
cmanallen merged 5 commits into
masterfrom
cmanallen/replays-video-new-category

Conversation

@cmanallen
Copy link
Copy Markdown
Member

@cmanallen cmanallen commented Jan 17, 2025

We currently offer unlimited replay mobile events for beta customers until April 6th. Customers who exhaust their web quota have their mobile quota blocked because they share the same category. I've updated the enforcement to use different counts for each event type. This is temporary and will be removed after the grace period expires.

@cmanallen cmanallen requested a review from a team as a code owner January 17, 2025 20:53
Copy link
Copy Markdown
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the now failing tests accordingly.

@cmanallen cmanallen requested a review from jjbayer January 21, 2025 15:17
Copy link
Copy Markdown
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a changelog entry (under **Features**) instead of using #skip-changelog?

@cmanallen
Copy link
Copy Markdown
Member Author

@jjbayer Yeah of course.

@cmanallen cmanallen merged commit 520187f into master Jan 21, 2025
@cmanallen cmanallen deleted the cmanallen/replays-video-new-category branch January 21, 2025 16:26
cmanallen added a commit that referenced this pull request Mar 6, 2025
…ideo" (#4554)

Replay videos are billed as of March 6th. This does not need to be
merged immediately. This is cleaning up unnecessary distinction between
events.

Reverts #4459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants