feat(pool): Try different queue size #4548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Mar 5, 2025
Member
Dav1dde
left a comment
Dav1dde
left a comment
There was a problem hiding this comment.
Why do you expect this to make a difference, the queue should never fill up?
Contributor
Author
Given our metrics it seems like that's correct, but there are some spikes. I want to just remove this hunch from my head, if it turns out to not cause any difference, we can cross out also that. |
iambriccardo
added a commit
that referenced
this pull request
Mar 5, 2025
This reverts commit c244409.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to increase the queue size by 5x to see if we get a reduction in utilization of the service. The goal with this is to see if the suspension and resumption of tasks, leads to longer poll times on the pool queue.
#skip-changelog