fix(geo): infer geo info even if ip toggle is on#4586
Merged
Conversation
Dav1dde
approved these changes
Mar 17, 2025
Member
Dav1dde
left a comment
Dav1dde
left a comment
There was a problem hiding this comment.
Maybe we have an integration test you can modify for this case or add one?
Contributor
Author
|
@Dav1dde I couldn't find a test so I added one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that geo informations will always be inferred, even if the setting to Prevent Storing of IPs is enabled.