Skip to content

ref(instr): Count contained items instead of raw envelope items #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

ref(instr): Count contained items instead of raw envelope items #4741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion relay-server/src/endpoints/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ fn emit_envelope_metrics(envelope: &Envelope) {
item_type = item.ty().name()
);
metric!(
counter(RelayCounters::EnvelopeItems) += 1,
counter(RelayCounters::EnvelopeItems) += item.item_count().unwrap_or(1),
item_type = item.ty().name(),
sdk = client_name.name(),
);
Expand Down
5 changes: 4 additions & 1 deletion relay-server/src/statsd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,10 @@ pub enum RelayCounters {
/// - `handling`: Either `"success"` if the envelope was handled correctly, or `"failure"` if
/// there was an error or bug.
EnvelopeRejected,
/// Number of items we processed per envelope.
/// Number of total envelope items we received.
///
/// Note: This does not count raw items, it counts the logical amount of items,
/// e.g. a single item container counts all its contained items.
EnvelopeItems,
/// Number of bytes we processed per envelope item.
EnvelopeItemBytes,
Expand Down
Loading