feat(spans): Backfill data from sentry_tags
#4803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Litarnus
reviewed
Jun 10, 2025
Dav1dde
reviewed
Jun 11, 2025
Dav1dde
approved these changes
Jun 12, 2025
Co-authored-by: David Herberth <david.herberth@sentry.io>
Member
|
Wondering if we should do |
Contributor
Author
|
I.e. the next paragraph in the linked snuba code? Is there a reason not to? |
Member
|
Discussed with the performance team, we should do all of the Snuba logic in Relay in the same order. But we can do it in a separate PR. |
loewenheim
added a commit
that referenced
this pull request
Jun 18, 2025
Continuing on from #4803, this populates `data` from `tags` for spans in `StoreService::produce_span`. The logic is based on https://github.com/getsentry/snuba/blob/4cf53a83cc5051551612b3ae8a5556228588f731/rust_snuba/src/processors/eap_items_span.rs#L164-L173.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This populates
datafromsentry_tagsfor spans inStoreService::produce_span. This logic already exists in Snuba: https://github.com/getsentry/snuba/blob/4cf53a83cc5051551612b3ae8a5556228588f731/rust_snuba/src/processors/eap_items_span.rs#L153-L162.This makes it necessary to parse
SpanKafkaMessage::dataas aBTreeMapinstead of aRawValuebecause otherwise it can't be modified.There is still an open question about what should happen if a key that would be inserted into
databased on a tag is already present. Right now I'm overwriting it, but it would be simple enough not to.Ref #4797. Ref RELAY-83.
#skip-changelog