fix(contexts): Normalize browser and os names with missing versions #4957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-wilfert
approved these changes
Jul 21, 2025
Member
|
Looks like there is still some test and code that need to be modified for the CI to pass. |
vaind
approved these changes
Jul 21, 2025
| "build": "23456", | ||
| "raw_description": "Microsoft Windows 10.1.23456" | ||
| } | ||
| "###); |
Contributor
There was a problem hiding this comment.
While not strictly related to the changes in this PR. It's weird that one of these gets parsed as Windows 11 and another with the full version number in the "os" context. Worth having a look.
Related to:
- Improve reporting of os information for Windows #4492
- OS
raw_descriptiondoes not get parsed: Windows 10 #1264
Or is it because we have a whitelist somewhere? I vaguely remember there being some code checking specific versions
| assert_eq!(None, os.build.value()); | ||
| assert_json_context!(os, @r###" | ||
| { | ||
| "os": "Nintendo OS", |
Contributor
To me this looks like it's only the Prospero test cases |
Dav1dde
force-pushed
the
dav1d/os-normalization
branch
from
84ca36c to
36dc0dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4956