fix(logs): Set logs retention to 30 days for full fidelity and downsampled datasets #5065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
phacops
changed the title
Dav1dde
approved these changes
Aug 18, 2025
| // Hard code both retentions for logs launch until we have separate retentions for | ||
| // different data categories. | ||
| #[cfg(feature = "processing")] | ||
| retention: _ctx.project_info.config.event_retention, |
Member
There was a problem hiding this comment.
Now the function no longer needs _ctx as an argument.
| #[cfg(feature = "processing")] | ||
| downsampled_retention: _ctx.project_info.config.downsampled_event_retention, | ||
| logs: all_logs, | ||
| downsampled_retention: Some(30), |
Member
There was a problem hiding this comment.
We can just remove downsampled_retention and retention alltogether from the ExpandedLogs struct now and then have the retentions as a const somewhere in logs/store.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided logs wouldn't get a downsampled retention just yet, so we need to default to using the full fidelity retention now.
Spans keep the downsampled retention. No other
TraceItemshould have it.