feat: Added correct limits to all forwarded requests#51
Merged
Conversation
Contributor
Author
|
In the process I noticed we have a legacy endpoint |
mitsuhiko
force-pushed
the
feature/limits
branch
6 times, most recently
from
0609a5a to
195936d
Compare
mitsuhiko
force-pushed
the
feature/limits
branch
from
195936d to
597036a
Compare
jan-auer
approved these changes
Aug 27, 2018
| - os: osx | ||
| env: SUITE=integration-test | ||
| install: easy_install virtualenv | ||
| env: PYTHON=python3.7 SUITE=integration-test |
Member
There was a problem hiding this comment.
nit: To simplify the setup, can we have the Makefile ensure a venv with the correct python version and instead use language: rust here? This should also make it easier to reproduce tests locally.
Member
|
@mitsuhiko Apart from my comment above, good to merge 👍 |
untitaker
approved these changes
Aug 27, 2018
Member
untitaker
left a comment
untitaker
left a comment
There was a problem hiding this comment.
lgtm though I quite dislike that we vendor our own globbing logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds limits to the forwarded requests. The test failures are consistent with #54