ref(pii): Change attr default/advanced rule logic #5112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how the `PiiProcessor` detects whether attributes should be scrubbed as objects (used for advanced rules) or identified with their `value` field (used for default rules). Previously, this was decided based on the presence of a segment of type `$log` in the processing state. Now there is an explicit mode setting. This doesn't change the behavior of the processor at all, it just makes the logic explicit and applicable to other objects than logs.
jjbayer
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how the
PiiProcessordetects whether attributes should be scrubbed as objects (used for advanced rules) or identified with theirvaluefield (used for default rules). Previously, this was decided based on the presence of a segment of type$login the processing state. Now there is an explicit mode setting. This doesn't change the behavior of the processor at all, it just makes the logic explicit and applicable to other objects than logs.ref: #5096. ref: RELAY-152.