fix(spanv2): Map error status to internal_error
#5127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, OTLP's `ERROR` status (`2`) and SpanV2's `error` status are mapped
to the SpanV1 status `unknown`. Since an `error` status means you definitely
had an error, the `unknown` status ("We do not know whether the transaction
failed or succeeded") does not seem appropriate.
The closest candidate for a generic error in SpanV1's status enum is
`internal_error`. Update the V2 to V1 mapping to use that instead.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mjq
changed the title
error status to internal_errorerror status to internal_error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, OTLP's
ERRORstatus (2) and SpanV2'serrorstatus are mapped to the SpanV1 statusunknown. Since anerrorstatus means you definitely had an error, theunknownstatus ("We do not know whether the transaction failed or succeeded") does not seem appropriate.The closest candidate for a generic error in SpanV1's status enum is
internal_error. Update the V2 to V1 mapping to use that instead.