feat(profiles): Drop transaction profile context if rate limited #5346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/drop-profile-ctx-on-rate-limit
branch
from
1d5350f to
5a3367d
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
jjbayer
approved these changes
Nov 5, 2025
| ctx.project_info, | ||
| ); | ||
| profile::transfer_id(&mut event, profile_id); | ||
| profile::remove_context_if_rate_limited(&mut event, managed_envelope, ctx); |
Member
There was a problem hiding this comment.
I should work faster, now I have to port this to the new transaction processor 😆 .
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Zylphrex
approved these changes
Nov 5, 2025
phacops
approved these changes
Nov 5, 2025
viglia
approved these changes
Nov 6, 2025
Dav1dde
force-pushed
the
dav1d/drop-profile-ctx-on-rate-limit
branch
from
b886108 to
16dc724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5071
Closes: RELAY-150
See linked issue for details, when the context should be dropped.
The entire thing is best effort (rate limits permanently change and the entire operation is order dependent), so checking cached rate limits should suffice.
Open questions: The issue mentions
profile chunksbut what about not chunked profiles? I tried to handle this (somewhat) by not checking the rate limit category for profiles and by skipping the removal if there is a profile in the same envelope.