fix(redis): Correctly size the Redis pools by default #5358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/redis-pool-size
branch
from
9598825 to
eab0d4b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Dav1dde
force-pushed
the
dav1d/redis-pool-size
branch
2 times, most recently
from
580326d to
e983559
Compare
Dav1dde
force-pushed
the
dav1d/redis-pool-size
branch
from
e983559 to
c66649a
Compare
jjbayer
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Redis pools are still sized without considering async pool concurrency. We're no longer in a Redis connection per thread world, we now have an additional pool concurrency to consider.
This increases right sizes the internal Redis pools with the total (worst case) concurrency in mind.