feat(replay): Remove the quantities logic from the store#5649
Merged
tobias-wilfert merged 2 commits intomasterfrom Feb 20, 2026
Merged
feat(replay): Remove the quantities logic from the store#5649tobias-wilfert merged 2 commits intomasterfrom
tobias-wilfert merged 2 commits intomasterfrom
Conversation
Dav1dde
approved these changes
Feb 19, 2026
tobias-wilfert
deleted the
tobias-wilfert/feat/improve-replay-quantities
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up to the replay rework #5580 this moves the quantities logic out of the store.
Note: The initial goal was to change the logic to count both web and native replays as 1
Replayhowever all options considered for this proved non-ideal (either not logical or not consistent). As such, we decided to keep the current quantities logic as is but remove it from the store.