Skip to content

fix(config): Increase default max_span_size from 1 MiB to 10 MiB#5780

Merged
vgrozdanic merged 2 commits intomasterfrom
fix/increase-max-span-size-default
Apr 8, 2026
Merged

fix(config): Increase default max_span_size from 1 MiB to 10 MiB#5780
vgrozdanic merged 2 commits intomasterfrom
fix/increase-max-span-size-default

Conversation

@vgrozdanic
Copy link
Copy Markdown
Member

@vgrozdanic vgrozdanic commented Apr 1, 2026

Increases the default max_span_size in relay config from 1 MiB to 10 MiB.

With the new DACI new limit per span is 1MB (this will be changed in sentry codebase to still come as a config), but that means that we now need to raise max_span_size to higher value.

max_span_size is used to check if the span will even get to trimming or will immediately get rejected, so if we left it at 1 MiB we'd never trim any larger span the limit, which is not the behavior that we want.

The change is done here, in the code, and not through config to address also the managed relays which do not read our k8s configs.

The previous 1 MiB default was too restrictive for spans in the spans_v2
pipeline, causing legitimate large spans to be rejected with HTTP 413.

Co-Authored-By: Claude <noreply@anthropic.com>
@vgrozdanic vgrozdanic marked this pull request as ready for review April 1, 2026 12:29
@vgrozdanic vgrozdanic requested a review from a team as a code owner April 1, 2026 12:29
@vgrozdanic vgrozdanic added this pull request to the merge queue Apr 7, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 7, 2026
@vgrozdanic vgrozdanic enabled auto-merge April 8, 2026 08:20
@vgrozdanic vgrozdanic added this pull request to the merge queue Apr 8, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2026
@vgrozdanic vgrozdanic added this pull request to the merge queue Apr 8, 2026
Merged via the queue into master with commit 6cecba0 Apr 8, 2026
59 of 86 checks passed
@vgrozdanic vgrozdanic deleted the fix/increase-max-span-size-default branch April 8, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants