Skip to content

ref(upload): Clean up objectstore error handling#5851

Merged
jjbayer merged 6 commits intomasterfrom
ref/objectstore-error-cleanup
Apr 17, 2026
Merged

ref(upload): Clean up objectstore error handling#5851
jjbayer merged 6 commits intomasterfrom
ref/objectstore-error-cleanup

Conversation

@jjbayer
Copy link
Copy Markdown
Member

@jjbayer jjbayer commented Apr 17, 2026

Follow-up from #5836 (comment) to prevent under- or over-reporting of metrics and errors:

  1. Log success metric in the innermost function as soon as the upload is successful.
  2. Log failure metric & error in the function that handles the error.

@jjbayer
Copy link
Copy Markdown
Member Author

jjbayer commented Apr 17, 2026

@cursor review

Comment thread relay-server/src/services/objectstore.rs
Comment thread relay-server/src/services/objectstore.rs Outdated
@jjbayer
Copy link
Copy Markdown
Member Author

jjbayer commented Apr 17, 2026

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 46e025c. Configure here.

@jjbayer jjbayer marked this pull request as ready for review April 17, 2026 09:36
@jjbayer jjbayer requested a review from a team as a code owner April 17, 2026 09:36
Copy link
Copy Markdown
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper error types, yay

@jjbayer jjbayer added this pull request to the merge queue Apr 17, 2026
Merged via the queue into master with commit 64743de Apr 17, 2026
31 checks passed
@jjbayer jjbayer deleted the ref/objectstore-error-cleanup branch April 17, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants