feat(spanv2): Implement container version 2#5881
Merged
Merged
Conversation
Dav1dde
force-pushed
the
dav1d/eap-ingest-settings
branch
from
51d06a8 to
f9c5277
Compare
Dav1dde
force-pushed
the
dav1d/eap-ingest-settings
branch
from
f9c5277 to
7324ea0
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Dav1dde
force-pushed
the
dav1d/eap-ingest-settings
branch
from
7324ea0 to
27007cc
Compare
Dav1dde
force-pushed
the
dav1d/eap-ingest-settings
branch
from
27007cc to
789a0dd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 789a0dd. Configure here.
loewenheim
reviewed
Apr 23, 2026
loewenheim
approved these changes
Apr 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
elramen
pushed a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #5869
Implements container version two for Spans: https://develop.sentry.dev/sdk/telemetry/spans/span-protocol/#version-and-ingest_settings-properties
Since the container attributes change how spans are normalized, I simplified the architecture of the spans processor to only allow a single type of span.
Mixing spans, was never officially supported just a "lucky" side-effect.
I plan on improving this code in #5882, for now I kept it kinda similar to the old (e.g. some outcomes).