feat(conventions): Add functions for <key> attributes#5940
Open
loewenheim wants to merge 2 commits intomasterfrom
Open
feat(conventions): Add functions for <key> attributes#5940loewenheim wants to merge 2 commits intomasterfrom
loewenheim wants to merge 2 commits intomasterfrom
Conversation
loewenheim
force-pushed
the
sebastian/conventions-interpolation-functions
branch
from
c8ddf18 to
ee012ab
Compare
Dav1dde
approved these changes
May 6, 2026
Member
Dav1dde
left a comment
Dav1dde
left a comment
There was a problem hiding this comment.
Beginning to think some tests would be useful, just not sure how to write the tests so they don't depend on conventions which may change with an update, but maybe that's okay.
E.g. we could have some tests that the key function actually formats correctly. Tests may also be partially auto generated by the build.rs.
Contributor
Author
To be fair, they do have a doctest each. How useful that is a different question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: INGEST-896