fix(spans): Set name based on transaction#5961
Conversation
Dav1dde
left a comment
There was a problem hiding this comment.
I think that's worth a change log entry, this is a visible behaviour change.
|
I wanna call this a bug fix, WDYT @Dav1dde? |
Dav1dde
left a comment
There was a problem hiding this comment.
Bug fix seems appropriate to me!
Co-authored-by: David Herberth <david.herberth@sentry.io>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d328d21. Configure here.
| - Set the name based on the transaction name when converting a transaction into a segment span. ([#5961](https://github.com/getsentry/relay/pull/5961)) | ||
| ======= | ||
| - Emit more precise outcome discard reasons for the Playstation, Minidump, and Attachments endpoints. ([#5950](https://github.com/getsentry/relay/pull/5950)) | ||
| >>>>>>> master |
There was a problem hiding this comment.
Unresolved merge conflict markers in CHANGELOG
High Severity
Git merge conflict markers (<<<<<<< sebastian/span-transaction-name, =======, >>>>>>> master) were committed to CHANGELOG.md. This leaves the file in a broken state — both changelog entries are present but surrounded by conflict markers, which will render as raw text. The conflict needs to be resolved to include both entries cleanly.
Reviewed by Cursor Bugbot for commit d328d21. Configure here.


When converting a transaction into a segment span, set the span's
data.span_namefield directly based on the transaction's name.This has several downstream effects:
namefield will be set based ondata.span_name, instead of being inferred from a combination of attributes. This means the V2 segment span'snamewill be the original transaction name.nameis copied into each child span'ssentry.segment.nameattribute. This means that each child span'ssentry.segment.namewill be the original transaction name.Fixes INGEST-905.