Skip to content

fix(spans): Set name based on transaction#5961

Open
loewenheim wants to merge 8 commits intomasterfrom
sebastian/span-transaction-name
Open

fix(spans): Set name based on transaction#5961
loewenheim wants to merge 8 commits intomasterfrom
sebastian/span-transaction-name

Conversation

@loewenheim
Copy link
Copy Markdown
Contributor

When converting a transaction into a segment span, set the span's data.span_name field directly based on the transaction's name.

This has several downstream effects:

  • When the segment span is converted to a V2 span, the name field will be set based on data.span_name, instead of being inferred from a combination of attributes. This means the V2 segment span's name will be the original transaction name.
  • Later, in the segment enricher, the segment span's name is copied into each child span's sentry.segment.name attribute. This means that each child span's sentry.segment.name will be the original transaction name.

Fixes INGEST-905.

@loewenheim loewenheim requested a review from a team as a code owner May 8, 2026 08:04
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 8, 2026

INGEST-905

Comment thread relay-event-schema/src/protocol/span/convert.rs
Copy link
Copy Markdown
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's worth a change log entry, this is a visible behaviour change.

@loewenheim
Copy link
Copy Markdown
Contributor Author

I wanna call this a bug fix, WDYT @Dav1dde?

@loewenheim loewenheim changed the title feat(spans): Set name based on transaction fix(spans): Set name based on transaction May 8, 2026
Copy link
Copy Markdown
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fix seems appropriate to me!

Comment thread CHANGELOG.md
loewenheim and others added 3 commits May 8, 2026 10:46
Copy link
Copy Markdown
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d328d21. Configure here.

Comment thread CHANGELOG.md
- Set the name based on the transaction name when converting a transaction into a segment span. ([#5961](https://github.com/getsentry/relay/pull/5961))
=======
- Emit more precise outcome discard reasons for the Playstation, Minidump, and Attachments endpoints. ([#5950](https://github.com/getsentry/relay/pull/5950))
>>>>>>> master
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolved merge conflict markers in CHANGELOG

High Severity

Git merge conflict markers (<<<<<<< sebastian/span-transaction-name, =======, >>>>>>> master) were committed to CHANGELOG.md. This leaves the file in a broken state — both changelog entries are present but surrounded by conflict markers, which will render as raw text. The conflict needs to be resolved to include both entries cleanly.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d328d21. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants