fix(spans): Restore top-level _performance_issues_spans#6045
Conversation
| pub span_op_defaults: BorrowedSpanOpDefaults<'a>, | ||
|
|
||
| /// Set a flag to enable performance issue detection on spans. | ||
| pub performance_issues_spans: bool, |
There was a problem hiding this comment.
Setting this flag is now centralized in forward_store.
| skip_serialization = "empty", | ||
| trim = false | ||
| )] | ||
| pub performance_issues_spans: Annotated<bool>, |
There was a problem hiding this comment.
This shouldn't be part of the span schema.
| downsampled_retention_days: retentions.downsampled, | ||
| event_id: None, | ||
| item: span, | ||
| performance_issues_spans: false, |
There was a problem hiding this comment.
This flag is only used for segment spans created from transactions.
| downsampled_retention_days: ctx.retention.downsampled, | ||
| event_id: None, | ||
| item: span, | ||
| performance_issues_spans: false, |
There was a problem hiding this comment.
This flag is only used for segment spans created from transactions.
| retention_days: retentions.standard, | ||
| downsampled_retention_days: retentions.downsampled, | ||
| event_id, | ||
| performance_issues_spans: false, |
There was a problem hiding this comment.
This is the initial value, but we conditionally overwrite it in forward_store.
| use relay_dynamic_config::Feature; | ||
|
|
There was a problem hiding this comment.
Nope, IDE did this because the function is guarded by feature = "processing".
| use relay_dynamic_config::Feature; | ||
|
|
There was a problem hiding this comment.
Is there a reason to put this inside here but use relay_protocol::Annotated; outside? I don't mind either but think having both the same way makes sense?
There was a problem hiding this comment.
Nope, IDE did this because the function is guarded by feature = "processing".
| if let Some(event) = work.event.value_mut() | ||
| && performance_issues_spans | ||
| { | ||
| event.performance_issues_spans = Annotated::new(true); |
There was a problem hiding this comment.
The comment on this is still /// Temporary flag that controls where performance issues are detected. Is the idea to eventually get rid of it?
There was a problem hiding this comment.
Yes it should eventually get removed.
3 participants
Restore top-level
_performance_issues_spans, but make it part of the kafka message instead of the span schema.Fixes INGEST-879