Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jul 17, 2020

@BYK BYK requested review from a team, jan-auer and untitaker July 17, 2020 11:25
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this block deploys or add to the run time? or is this a separate/parallel job?

@BYK
Copy link
Member Author

BYK commented Jul 17, 2020

will this block deploys or add to the run time? or is this a separate/parallel job?

If this test fails, we won't publish the image to Docker Hub. I'd also like to make this check required after this.

@BYK BYK merged commit 1bfef45 into master Jul 17, 2020
@BYK BYK deleted the byk/test/onpremise branch July 17, 2020 12:22
@jan-auer
Copy link
Member

jan-auer commented Jul 17, 2020

If this test fails, we won't publish the image to Docker Hub.

@BYK Please publish the image regardless. We can make the check required, but ops needs a way to deploy commits even if tests are failing for whatever reason. We've had situations in the past where we needed to fast-track emergency bugfixes to Relay even though Sentry or other services were broken at the time.

@BYK
Copy link
Member Author

BYK commented Jul 17, 2020

This only blocks Docker Hub pushes. The image is always available on us.gcr.io/sentryio/relay as that's the image we use to test on-premise here.

@jan-auer
Copy link
Member

That's perfect, thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants