meta: Fix CODEOWNERS #884
Merged
meta: Fix CODEOWNERS #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners#example-of-a-codeowners-file, the order matters and **the last line that matches** takes precedense. That makes all definitions above the `*` catch-all definition useless. This PR fixes that.
untitaker
approved these changes
Dec 15, 2020
jan-auer
added a commit
that referenced
this pull request
Dec 18, 2020
* master: feat: Enable use of multiple value types per field (#882) fix(user-report): Make all fields but event-id optional (#886) release: 20.12.1 release: 20.12.0 ci(release): Move to getsentry/publish for releases (#885) meta: Fix CODEOWNERS (#884) fix: Also build rdkafka with ssl if ssl feature is enabled (#881)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners#example-of-a-codeowners-file, the order matters and the last line that matches takes precedence. That makes all definitions above the
*catch-all definition useless. This PR fixes that.#skip-changelog