Fix annotations of CallList#593
Merged
markstory merged 1 commit intogetsentry:masterfrom Oct 12, 2022
Merged
Conversation
Collaborator
|
hi, thanks please add new version in changelog and add your item there |
b958e84 to
046e706
Compare
Contributor
Author
|
Done. |
beliaev-maksim
approved these changes
Oct 12, 2022
Member
|
Thank you 🎉 |
Merged
Collaborator
|
closes #610 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 0.22.0, mypy started to complain about constructions
rsps.calls[0].requestwith an errorbecause it wasn't able to differentiate between the return types. I added
overloadannotation to handle that.