feat(rrweb): Extend ignoreCSSAttributes to support inline styles
#252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends `ignoreCSSAttributes` so that it works for inline styles as well as from stylesheet rules. Closes #250
billyvg
force-pushed
the
billy/replay-764-images-shown-in-replays-despite-maskallmedia-set-to-true
branch
from
33b98d5 to
a9e62c7
Compare
billyvg
deleted the
billy/replay-764-images-shown-in-replays-despite-maskallmedia-set-to-true
branch
billyvg
added a commit
that referenced
this pull request
Oct 22, 2025
) This extends `ignoreCSSAttributes` so that it works for inline styles as well as from stylesheet rules. Closes #250
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 23, 2025
Pass `ignoreCSSAttributes` with `background-imgae` to ignore background images when `blockAllMedia` is enabled. `ignoreCSSAttributes` was expanded in [this PR](getsentry/rrweb#252) so that it also works for inline styles.
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 24, 2025
Pass `ignoreCSSAttributes` with `background-imgae` to ignore background images when `blockAllMedia` is enabled. `ignoreCSSAttributes` was expanded in [this PR](getsentry/rrweb#252) so that it also works for inline styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends
ignoreCSSAttributesso that it works for inline styles as well as from stylesheet rules. Closes #250