Conversation
9f5dce1 to
89f48d0
Compare
89f48d0 to
d0d9507
Compare
d0d9507 to
151753b
Compare
loewenheim
reviewed
Oct 28, 2025
Contributor
loewenheim
left a comment
There was a problem hiding this comment.
This is a good start, but it's going to need more work, see the comments about outline call site records.
loewenheim
reviewed
Nov 7, 2025
Contributor
loewenheim
left a comment
There was a problem hiding this comment.
Other than disentangling the prepare_frame_for_mapping function this looks good now.
loewenheim
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only targets
ProguardMappingat the moment, will addressProguardCachein a separate PRPart of #59