Skip to content

fix(r8-tests): Correctly handle no-line mappings#72

Merged
romtsn merged 5 commits intorz/feat/r8-tests-ambiguousfrom
rz/fix/r8-tests-ambiguous-no-line
Jan 28, 2026
Merged

fix(r8-tests): Correctly handle no-line mappings#72
romtsn merged 5 commits intorz/feat/r8-tests-ambiguousfrom
rz/fix/r8-tests-ambiguous-no-line

Conversation

@romtsn
Copy link
Copy Markdown
Member

@romtsn romtsn commented Dec 23, 2025

  • Improved stacktrace parsing to handle frames that omit a line number (e.g. (Unknown), (Unknown Source), (Foo.java)) by treating them as line 0 so they can be retraced.
  • Enhanced retracing behavior for unknown-line frames:
    • Prefer base (no-line) mappings when the stacktrace frame has no line info.
    • Still prefer line-specific mappings when a concrete line is present (skipping 0:0 / base entries appropriately).
    • Added best-effort class remapping even when the method name isn’t mapped (replicates symbolicator behaviour -- we can probably ditch it from symbolicator once this is shipped)
  • Aligned cache behavior with mapper behavior:
    • Cache serialization no longer drops base/no-line member mappings (instead, we check it during remapping)
    • Cache remapping now mirrors mapper rules for unknown-line frames (including deduplication)

The tests in #71 should pass with this PR

@romtsn romtsn changed the title feat(r8-tests): Add R8 ambiguous tests fix(r8-tests): Correctly handle no-line mappings Dec 23, 2025
@romtsn romtsn requested a review from loewenheim December 23, 2025 11:35
@romtsn romtsn force-pushed the rz/fix/r8-tests-ambiguous-no-line branch from 07dbf0f to 59a8dd7 Compare December 23, 2025 12:18
@romtsn romtsn force-pushed the rz/fix/r8-tests-ambiguous-no-line branch from cf3f732 to 82d62e3 Compare January 27, 2026 10:53
Copy link
Copy Markdown
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from one comment

Comment thread src/cache/mod.rs
Copy link
Copy Markdown
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from one comment

@romtsn romtsn merged commit c87c310 into rz/feat/r8-tests-ambiguous Jan 28, 2026
5 checks passed
@romtsn romtsn deleted the rz/fix/r8-tests-ambiguous-no-line branch January 28, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants