Skip to content

feat(r8-tests): Add R8 source file tests#74

Merged
romtsn merged 16 commits intomasterfrom
rz/feat/r8-tests-source-files
Jan 30, 2026
Merged

feat(r8-tests): Add R8 source file tests#74
romtsn merged 16 commits intomasterfrom
rz/feat/r8-tests-source-files

Conversation

@romtsn
Copy link
Copy Markdown
Member

@romtsn romtsn commented Dec 23, 2025 •
edited
Loading

Part of #40

Unsure if we actually have to handle such weird inputs, but I guess we better be on the safe side and parse those correctly.

R8 Retrace Test Coverage

  • Inlining (13 tests) - inline frames, line numbers, source files, rewriteFrame rules
  • Ambiguous Methods (21 tests) - multiple methods → same obfuscated name, alternatives
  • Outlines (4 tests) - outline callsites, nested outlines, inline-in-outline
  • Synthetic/Lambda (3 tests) - lambda methods, synthetic bridges
  • Source File Edge Cases (7 tests) - colons, unicode, multiple dots, synthesized names
  • Line Number Handling (10 tests) - spans, preambles, invalid ranges, missing lines
  • Exception Handling (6 tests) - obfuscated exceptions, suppressed, circular refs
  • Method Overloading (4 tests) - overloads with/without ranges
  • Special Formats (4 tests) - Java 9+ modules, logcat format, auto-detect

@romtsn romtsn requested a review from loewenheim December 23, 2025 16:14
romtsn
romtsn commented Jan 21, 2026
View reviewed changes
romtsn
romtsn commented Jan 21, 2026
View reviewed changes
romtsn
romtsn commented Jan 21, 2026
View reviewed changes
romtsn added 4 commits January 28, 2026 18:15
@romtsn
Merge branch 'master' into rz/feat/r8-tests-synthetic
e44baf3
@romtsn
Remove r8-ambiguous.NOTES
a9125eb
@romtsn
Merge branch 'rz/feat/r8-tests-synthetic' into rz/feat/r8-tests-sourc…
c2fdcab 
…e-files
@romtsn
fix(r8-tests): Fix no-line original line preservation for source file…
764b7f4 
… edge cases (#79)

- Split source file names by the last `:` occurrence 
- Additionally fixes no-line original line preservation
- Also removes `tests/r8-source-file-edge-cases.NOTES.md`
- Removes two tests that we agreed do not need fixing
@romtsn romtsn changed the base branch from rz/feat/r8-tests-synthetic to master January 29, 2026 22:29
@romtsn
Copy link
Copy Markdown
Member Author

romtsn commented Jan 29, 2026

re-targeted this to master to bypass synthetic failures for now

@romtsn romtsn merged commit fb53ccf into master Jan 30, 2026
7 checks passed
@romtsn romtsn deleted the rz/feat/r8-tests-source-files branch January 30, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loewenheim loewenheim loewenheim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romtsn @loewenheim