fix(r8-tests): Normalize inverted line ranges in mapping parser#82
Merged
romtsn merged 2 commits intorz/feat/r8-tests-line-number-handlingfrom Feb 16, 2026
Conversation
Inverted minified ranges (e.g. `5:3:void main() -> main`) and inverted original ranges (e.g. `2:5:void main():5:2 -> main`) are now normalized by swapping the start/end values. This fixes incorrect line interpolation for these edge cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
romtsn
changed the title
loewenheim
reviewed
Feb 10, 2026
Normalize minified and original ranges independently instead of swapping the original range when the minified range is inverted and then potentially swapping it back. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
loewenheim
approved these changes
Feb 13, 2026
romtsn
merged commit 7916939
into
rz/feat/r8-tests-line-number-handling
3 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5:3:void main() -> main) by swapping start/end values2:5:void main():5:2 -> main) independentlyr8-line-number-handling)Test plan
test_invalid_minified_range_stacktracenow passestest_invalid_original_range_stacktracenow passesmake test,make format,make lint)🤖 Generated with Claude Code