feat(r8): Sort ambiguous no-range entries alphabetically#87
Merged
romtsn merged 1 commit intorz/feat/r8-tests-line-number-handlingfrom Feb 16, 2026
Merged
Conversation
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
5ab7394 to
62eb94d
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
92b293d to
a2ff34c
Compare
loewenheim
reviewed
Feb 10, 2026
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
62eb94d to
eda47ad
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
2 times, most recently
from
b1ce9ec to
9db871a
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
2 times, most recently
from
e694bdf to
ed74fe4
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
9db871a to
86ca9fb
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
ed74fe4 to
8eb23e5
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
8eb23e5 to
f6d1201
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
86ca9fb to
b692685
Compare
loewenheim
approved these changes
Feb 13, 2026
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
b692685 to
b9b4841
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
2 times, most recently
from
00087b5 to
0658c98
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
b9b4841 to
62ed8da
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
0658c98 to
f94b546
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
2 times, most recently
from
0af8489 to
1951c06
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
f94b546 to
d48f3f2
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
1951c06 to
d1a627a
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
d48f3f2 to
5f1a780
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
d1a627a to
352028f
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
2 times, most recently
from
956a341 to
232a9b7
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
352028f to
b4acde2
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
232a9b7 to
2397ca1
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
74b317e to
ea0879b
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
2397ca1 to
399ec14
Compare
Base automatically changed from
rz/fix/r8-tests-span-and-fallback
to
rz/feat/r8-tests-line-number-handling
February 16, 2026 13:32
When multiple no-range entries with different original method names all have line mappings, sort them alphabetically. Bare method entries (no line mapping) preserve original mapping file order. Fixes test_single_line_no_line_number_stacktrace — all 10 R8 line number handling tests now pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
romtsn
force-pushed
the
rz/fix/r8-tests-ambiguous-sorting
branch
from
399ec14 to
56d7246
Compare
romtsn
merged commit a346b38
into
rz/feat/r8-tests-line-number-handling
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
original_startline.is_some()), sort them alphabetically by original method nameoriginal_startline.is_none()) continue to preserve original mapping file orderFixes
test_single_line_no_line_number_stacktrace— all 10 R8 line number handling tests now pass.Test plan
test_single_line_no_line_number_stacktracenow passes (ordering:main3beforemethod3)test_ambiguous_stacktracestill passes (bare methods preserve file order:foobeforebar)make formatandmake lintpass