Merged
Conversation
lynnagara
reviewed
May 6, 2025
| def __init__(self, key: str, url: str) -> None: | ||
| self.__notifier = slack_notifier.SlackNotifier(key, url) | ||
|
|
||
| def log(self, user: str, group: str, function: str, region: str) -> None: |
Member
There was a problem hiding this comment.
i'm starting to wonder if it's better/less verbose to pass a list of regions here and log a single message since we send them all to the same place?
Contributor
Author
There was a problem hiding this comment.
I think this is fine the way it is, I think it would be nice to be explicit about what regions something ran in but in a loud way (maybe some test regions we don't care about)
lynnagara
reviewed
May 6, 2025
Comment on lines
+145
to
+146
| eng_pipes_key=audit_log_data["slack"]["eng_pipes_key"], | ||
| eng_pipes_url=audit_log_data["slack"]["eng_pipes_url"], |
Member
There was a problem hiding this comment.
you might need to adjust the schema to allow those fields? also what doeseng_pipes mean?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds slack event notifs for write events.